logging: fully convert the ERROR level to ERR
authorAdam Simpkins <simpkins@fb.com>
Thu, 22 Jun 2017 00:23:21 +0000 (17:23 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Thu, 22 Jun 2017 00:35:56 +0000 (17:35 -0700)
commit53f2f752563152c9b10cfe36030aa871927f795a
treee3c5abbaf8323e50274f75a988bae0ecf3ad4f12
parentcffc8a776b21a070f0af6ed0748452c329ad6e5f
logging: fully convert the ERROR level to ERR

Summary:
Switch all code in the logging library from using `ERROR` to `ERR`,
and remove the `ERROR` LogLevel entirely, even if it is not already
defined as a macro.

Previously the code kept `ERROR` available as a LogLevel name if it had
not already been defined as a macro (which is done by common Windows header
files).  However, this made for inconsistent behavior, and made it easy to
write code that would not be portable to Windows.

This diff fully drops the `ERROR` name for consistency across platforms.

Reviewed By: wez

Differential Revision: D5288600

fbshipit-source-id: 8d2d52e955959c278345fc9c2086c7cacf9660f9
folly/experimental/logging/GlogStyleFormatter.cpp
folly/experimental/logging/LogCategory.cpp
folly/experimental/logging/LogLevel.h
folly/experimental/logging/LoggerDB.cpp
folly/experimental/logging/test/GlogFormatterTest.cpp
folly/experimental/logging/test/LogCategoryTest.cpp
folly/experimental/logging/test/LogLevelTest.cpp
folly/experimental/logging/test/LogMessageTest.cpp
folly/experimental/logging/test/LoggerDBTest.cpp
folly/experimental/logging/test/LoggerTest.cpp
folly/experimental/logging/test/PrintfTest.cpp