Rename Instruction::isIdenticalTo to Instruction::isIdenticalToWhenDefined,
authorDan Gohman <gohman@apple.com>
Tue, 25 Aug 2009 22:11:20 +0000 (22:11 +0000)
committerDan Gohman <gohman@apple.com>
Tue, 25 Aug 2009 22:11:20 +0000 (22:11 +0000)
commit58cfa3b13752579c86cf85270d49f9ced0942f2f
treee2d88c43f06255610357c7c9ee6caa8883523454
parent415c8cf837439401f2df75d992d7e296d1d6746a
Rename Instruction::isIdenticalTo to Instruction::isIdenticalToWhenDefined,
and introduce a new Instruction::isIdenticalTo which tests for full
identity, including the SubclassOptionalData flags. Also, fix the
Instruction::clone implementations to preserve the SubclassOptionalData
flags. Finally, teach several optimizations how to handle
SubclassOptionalData correctly, given these changes.

This fixes the counterintuitive behavior of isIdenticalTo not comparing
the full value, and clone not returning an identical clone, as well as
some subtle bugs that could be caused by these.

Thanks to Nick Lewycky for reporting this, and for an initial patch!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@80038 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/InstrTypes.h
include/llvm/Instruction.h
include/llvm/Instructions.h
include/llvm/Value.h
lib/Transforms/IPO/MergeFunctions.cpp
lib/Transforms/Scalar/InstructionCombining.cpp
lib/Transforms/Utils/BasicBlockUtils.cpp
lib/Transforms/Utils/SimplifyCFG.cpp
lib/VMCore/Instruction.cpp
lib/VMCore/Instructions.cpp