netfilter: xt_recent: fix regression in rules using a zero hit_count
authorPatrick McHardy <kaber@trash.net>
Mon, 22 Mar 2010 17:25:20 +0000 (18:25 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 1 Apr 2010 22:58:47 +0000 (15:58 -0700)
commit5a32ab6f23dd07b97a6095d6ddbfa79c47cf3bbd
tree53ac43d6dfe6ddc588523cb740493e19bbdebea0
parent710b70e8150e412aa809fadb028147952c56a4cc
netfilter: xt_recent: fix regression in rules using a zero hit_count

commit ef1691504c83ba3eb636c0cfd3ed33f7a6d0b4ee upstream.

Commit 8ccb92ad (netfilter: xt_recent: fix false match) fixed supposedly
false matches in rules using a zero hit_count. As it turns out there is
nothing false about these matches and people are actually using entries
with a hit_count of zero to make rules dependant on addresses inserted
manually through /proc.

Since this slipped past the eyes of three reviewers, instead of
reverting the commit in question, this patch explicitly checks
for a hit_count of zero to make the intentions more clear.

Reported-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/netfilter/xt_recent.c