Fix the unaligned string toLowerAscii test
authorBrian Pane <brianp@fb.com>
Mon, 21 Jul 2014 18:26:19 +0000 (11:26 -0700)
committerChip Turner <chip@fb.com>
Fri, 25 Jul 2014 16:06:09 +0000 (09:06 -0700)
commit5d36a4ff4e89367e9aee5517f60322c79c4c3c0d
treeaa9ce4205b3d96663b400f0cc29ab3f90851e3ca
parent1f4f30304bb22cd7e4320ea73490132259c87d8e
Fix the unaligned string toLowerAscii test

Summary:
* The test computed nonaligned inputs but then copied them into temporary
buffers to compare different implementations. The temporary buffers
were word-aligned.
* This diff keeps the temp buffers but ensures that the data in them
keeps the original input's alignment.

Test Plan:
* Ran the test case with a modified String.cpp containing an assert to
catch unaligned reads.  The assert failed, as expected, on a copy
of the code without the fix from D1434585

Reviewed By: meyering@fb.com

Subscribers: ruibalp

FB internal diff: D1435028

Tasks: 4696800
folly/test/StringTest.cpp