staging: ion: Fix possible null pointer dereference
authorJohn Stultz <john.stultz@linaro.org>
Tue, 17 Dec 2013 05:07:52 +0000 (21:07 -0800)
committerColin Cross <ccross@android.com>
Fri, 20 Dec 2013 03:25:38 +0000 (19:25 -0800)
commit60e11dfc002962181fe4f0db54b33c65fee02c52
treeb4555636ebbc20ea6cc8f0798ecddcc3df9c3b3f
parentd232ba2bea468a7d12d826d0fe62b3f8a9ba8d10
staging: ion: Fix possible null pointer dereference

The kbuild test robot reported:

drivers/staging/android/ion/ion_system_heap.c:122 alloc_largest_available() error: potential null dereference 'info'.  (kmalloc returns null)

Where the pointer returned from kmalloc goes unchecked for failure.

This patch checks the return for NULL, and reworks the logic, as
suggested by Colin, so we allocate the page_info structure first.

Acked-by: Colin Cross <ccross@android.com>
Cc: Android Kernel Team <kernel-team@android.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ion/ion_system_heap.c