tty: disable unbind for old 74xx based serial/mpsc console port
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Tue, 13 Oct 2015 23:06:30 +0000 (19:06 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 Oct 2015 04:18:30 +0000 (21:18 -0700)
commit6200cbaf62d481007cb07e73f67da77bc161ae96
tree140cfeea7a9de27387285ff4c4fc7c3728758034
parent06e7bd1f9bd86a47e1824f02a821b198eafeb7b6
tty: disable unbind for old 74xx based serial/mpsc console port

We recently got rid of some modular code in this driver and also
got rid of the unused ".remove" function at the same time.  Thierry
noted that it was however possible to force the remove through the
bind/unbind interface.

Since this is a console device used on 2005 vintage 74xx based
powerpc embedded targets, and is essentially always used in
conjunction with SERIAL_MPSC_CONSOLE=y -- there is no sane reason
anyone would ever want to unbind the builtin driver and lose the
console.  So we just explicitly block bind/unbind operations and
prevent root from shooting themselves in the foot.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-serial@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/mpsc.c