ARM: 7403/1: tls: remove covert channel via TPIDRURW
authorWill Deacon <will.deacon@arm.com>
Fri, 27 Apr 2012 11:45:07 +0000 (12:45 +0100)
committer黄涛 <huangtao@rock-chips.com>
Tue, 29 May 2012 02:14:36 +0000 (10:14 +0800)
commit62ef46fdc59b65442643f0475265588fd95a9fd9
tree6a4bbfd68bd621a5a0543970f0d072e26237e9fc
parent053926b9608fc964eef56d8b278a049b4d01b9b8
ARM: 7403/1: tls: remove covert channel via TPIDRURW

commit 6a1c53124aa161eb624ce7b1e40ade728186d34c upstream.

TPIDRURW is a user read/write register forming part of the group of
thread registers in more recent versions of the ARM architecture (~v6+).

Currently, the kernel does not touch this register, which allows tasks
to communicate covertly by reading and writing to the register without
context-switching affecting its contents.

This patch clears TPIDRURW when TPIDRURO is updated via the set_tls
macro, which is called directly from __switch_to. Since the current
behaviour makes the register useless to userspace as far as thread
pointers are concerned, simply clearing the register (rather than saving
and restoring it) will not cause any problems to userspace.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/include/asm/tls.h