projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 541d120) | patch
Handle take(-1) better
authorTom Jackson <tjackson@fb.com>
Wed, 9 Sep 2015 19:23:51 +0000 (12:23 -0700)
committerfacebook-github-bot-4 <folly-bot@fb.com>
Wed, 9 Sep 2015 20:20:16 +0000 (13:20 -0700)
commit6699f91a5664b78f767904ccdfcfdb0e23b44865
tree06ec0d42c0ad43f864763522eaafda1a55adc6f5tree | snapshot
parent541d12092aba15dae59710a36d9b72dfc28b84d3commit | diff
Handle take(-1) better

Summary: It's easy to accidentally pass a negative value to ##take()##, which leads to underflow on conversion to ##size_t##.

Reviewed By: @​rosephilip, @philippv

Differential Revision: D2421459
folly/gen/Base-inl.h diff | blob | history
folly/gen/test/BaseTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.