Revert "indvars: Improve LFTR by eliminating truncation when comparing
authorChandler Carruth <chandlerc@gmail.com>
Fri, 12 Jul 2013 11:18:55 +0000 (11:18 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Fri, 12 Jul 2013 11:18:55 +0000 (11:18 +0000)
commit6f0ec20e8fa23e9588205ea0eaba8f3021abe1ac
tree4922e9ce6f2aed915948586459a599215edbc4b9
parentdd51a0c1e0b3cce8093244533b3505668d16f218
Revert "indvars: Improve LFTR by eliminating truncation when comparing
against a constant."

This reverts commit r186107. It didn't handle wrapping arithmetic in the
loop correctly and thus caused the following C program to count from
0 to UINT64_MAX instead of from 0 to 255 as intended:

  #include <stdio.h>
  int main() {
    unsigned char first = 0, last = 255;
    do { printf("%d\n", first); } while (first++ != last);
  }

Full test case and instructions to reproduce with just the -indvars pass
sent to the original review thread rather than to r186107's commit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186152 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Transforms/Scalar/IndVarSimplify.cpp
test/Transforms/IndVarSimplify/exitcnt-const-arstart-const-opt.ll [deleted file]