Net, mac80211: Fix resource leak in ieee80211_rx_h_mesh_fwding()
authorJesper Juhl <jj@chaosbits.net>
Sat, 14 Jan 2012 20:52:17 +0000 (21:52 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 16 Jan 2012 20:01:15 +0000 (15:01 -0500)
commit74b8cc3d592e5e884123eb99960a9f064223eaab
tree293597e27723e538e60d5fa734de152070b9e136
parent7a532fe7131216a02c81a6c1b1f8632da1195a58
Net, mac80211: Fix resource leak in ieee80211_rx_h_mesh_fwding()

We may leak the 'fwd_skb' we skb_copy() in ieee80211_rx_h_mesh_fwding() if
we take the 'else' branch in the 'if' statement just below. If we take
that branch we'll end up returning from the function and since we've not
assigned 'fwd_skb' to anything at that point, we leak it when the variable
goes out of scope.

The simple fix seems to be to just kfree_skb(fwd_skb); just before we
return. That is what this patch does.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/rx.c