ARM: Prevent ARMAsmParser::shouldOmitCCOutOperand() from misidentifying certain Thumb...
authorTilmann Scheller <tilmann.scheller@googlemail.com>
Wed, 3 Jul 2013 20:38:01 +0000 (20:38 +0000)
committerTilmann Scheller <tilmann.scheller@googlemail.com>
Wed, 3 Jul 2013 20:38:01 +0000 (20:38 +0000)
commit79c163d6ddeb84ea1743eca0644688951bfc5a97
tree467dc3af27ee3b9bf1e6f11395e7f7fc25e46f6f
parent08ebdc73de5e3396bc17b928ad16af523837e660
ARM: Prevent ARMAsmParser::shouldOmitCCOutOperand() from misidentifying certain Thumb2 add immediate T3 encodings.

Before the fix Thumb2 instructions of type "add rD, rN, #imm" (T3 encoding, see ARM ARM A8.8.4) with rD and rN both being low registers (r0-r7) were classified as having the T4 encoding.

The T4 encoding doesn't have a cc_out operand so for above instructions the operand gets erroneously removed, corrupting the token stream and leading to parse errors later in the process.

This bug prevented "add r1, r7, #0xcbcbcbcb" from being assembled correctly.

Fixes <rdar://problem/14224440>.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185575 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/ARM/AsmParser/ARMAsmParser.cpp
test/MC/ARM/basic-thumb2-instructions.s