[MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme.
authorLang Hames <lhames@gmail.com>
Wed, 26 Nov 2014 06:53:26 +0000 (06:53 +0000)
committerLang Hames <lhames@gmail.com>
Wed, 26 Nov 2014 06:53:26 +0000 (06:53 +0000)
commit7acaefabf62d31a3edc830e06385495b73bdb8a8
treec6b9cccbbdb86eb6ae04c02fc09de9ae84b9b37c
parent568f7e8228a560753c23842a81817b6b3211046e
[MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme.

Previously, when loading an object file, RuntimeDyld (1) took ownership of the
ObjectFile instance (and associated MemoryBuffer), (2) potentially modified the
object in-place, and (3) returned an ObjectImage that managed ownership of the
now-modified object and provided some convenience methods. This scheme accreted
over several years as features were tacked on to RuntimeDyld, and was both
unintuitive and unsafe (See e.g. http://llvm.org/PR20722).

This patch fixes the issue by removing all ownership and in-place modification
of object files from RuntimeDyld. Existing behavior, including debugger
registration, is preserved.

Noteworthy changes include:

(1) ObjectFile instances are now passed to RuntimeDyld by const-ref.
(2) The ObjectImage and ObjectBuffer classes have been removed entirely, they
    existed to model ownership within RuntimeDyld, and so are no longer needed.
(3) RuntimeDyld::loadObject now returns an instance of a new class,
    RuntimeDyld::LoadedObjectInfo, which can be used to construct a modified
    object suitable for registration with the debugger, following the existing
    debugger registration scheme.
(4) The JITRegistrar class has been removed, and the GDBRegistrar class has been
    re-written as a JITEventListener.

This should fix http://llvm.org/PR20722 .

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@222810 91177308-0d34-0410-b5e6-96231b3b80d8
32 files changed:
include/llvm/ExecutionEngine/JITEventListener.h
include/llvm/ExecutionEngine/ObjectBuffer.h [deleted file]
include/llvm/ExecutionEngine/ObjectImage.h [deleted file]
include/llvm/ExecutionEngine/RTDyldMemoryManager.h
include/llvm/ExecutionEngine/RuntimeDyld.h
lib/ExecutionEngine/CMakeLists.txt
lib/ExecutionEngine/ExecutionEngine.cpp
lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
lib/ExecutionEngine/JITEventListener.cpp [deleted file]
lib/ExecutionEngine/MCJIT/MCJIT.cpp
lib/ExecutionEngine/MCJIT/MCJIT.h
lib/ExecutionEngine/MCJIT/ObjectBuffer.h [new file with mode: 0644]
lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp
lib/ExecutionEngine/RuntimeDyld/CMakeLists.txt
lib/ExecutionEngine/RuntimeDyld/GDBRegistrar.cpp [deleted file]
lib/ExecutionEngine/RuntimeDyld/GDBRegistrationListener.cpp [new file with mode: 0644]
lib/ExecutionEngine/RuntimeDyld/JITRegistrar.h [deleted file]
lib/ExecutionEngine/RuntimeDyld/ObjectImageCommon.h [deleted file]
lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h
lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOAArch64.h
lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h
lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOI386.h
lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOX86_64.h
tools/lli/RemoteMemoryManager.cpp
tools/lli/RemoteMemoryManager.h
tools/llvm-jitlistener/llvm-jitlistener.cpp
tools/llvm-rtdyld/llvm-rtdyld.cpp