Fix a nasty bug in DAGCombine of STORE nodes.
authorOwen Anderson <resistor@mac.com>
Thu, 19 Mar 2015 22:48:57 +0000 (22:48 +0000)
committerOwen Anderson <resistor@mac.com>
Thu, 19 Mar 2015 22:48:57 +0000 (22:48 +0000)
commit8154ef7589acc76850d6e430adfc0d60e82d94cf
tree9f5cc7e35299a0aac5c6df7fb7ef326164334633
parent53f788786fc103f516e4b9a7fcfc3a8f21e48918
Fix a nasty bug in DAGCombine of STORE nodes.

This is very related to the bug fixed in r174431.  The problem is that
SelectionDAG does not include alignment in the uniquing of loads and
stores.  When an otherwise no-op DAGCombine would increase the alignment
of a load or store, the original node would be returned (with the
alignment increased), which would cause the node not to be processed by
any further DAGCombines.

I don't have a direct testcase for this that manifests on an in-tree
target, but I did see some noise in the tests for other targets and have
updated them for it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@232780 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
test/CodeGen/ARM/2014-01-09-pseudo_expand_implicit_reg.ll
test/CodeGen/PowerPC/anon_aggr.ll
test/CodeGen/Thumb2/2013-03-02-vduplane-nonconstant-source-index.ll