ipv6: fix incorrect route 'expires' value passed to userspace
authorLi Wei <lw@cn.fujitsu.com>
Sun, 29 Jul 2012 16:01:30 +0000 (16:01 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Jul 2012 06:18:31 +0000 (23:18 -0700)
commit8253947e2cdfb14717c9212b751b7aec9ea9ef5e
tree9089fdfff63ec45eec1cd49d74ca53b3a4096226
parentb41a9a66f67817f8acd85bd650e012a14da39faa
ipv6: fix incorrect route 'expires' value passed to userspace

When userspace use RTM_GETROUTE to dump route table, with an already
expired route entry, we always got an 'expires' value(2147157)
calculated base on INT_MAX.

The reason of this problem is in the following satement:
rt->dst.expires - jiffies < INT_MAX
gcc promoted the type of both sides of '<' to unsigned long, thus
a small negative value would be considered greater than INT_MAX.

With the help of Eric Dumazet, do the out of bound checks in
rtnl_put_cacheinfo(), _after_ conversion to clock_t.

Signed-off-by: Li Wei <lw@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c
net/ipv6/route.c