projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b692cb2) | patch
stop prereserving space in toAppend
authorMarcin Pawlowski <mpawlowski@fb.com>
Wed, 8 Oct 2014 19:00:18 +0000 (12:00 -0700)
committerAndrii Grynenko <andrii@fb.com>
Wed, 15 Oct 2014 00:55:49 +0000 (17:55 -0700)
commit853d5b59ba6ac1743b876ea43424db9606229965
tree35cd2f9d8439cdb9b5dc5bef5ebc150fe71f137ctree | snapshot
parentb692cb2fa27911cbe3d307351cb786a8301f99efcommit | diff
stop prereserving space in toAppend

Summary:
previous change would cause reserving
as much as needed in toAppend for all arguements.
This had bad consequences for appending in a loop,
described here: https://phabricator.fb.com/D1420588#22
Not split the interfaces so that user has to decide

Test Plan: unit tests

Reviewed By: soren@fb.com

Subscribers: trunkagent, njormrod

FB internal diff: D1601614

Tasks: 5303991
folly/Conv.h diff | blob | history
folly/test/ConvTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.