[SCSI] fix OOPS due to clearing eh_action prior to aborting eh command
authorMichael Reed <mdr@sgi.com>
Thu, 8 Dec 2005 03:46:27 +0000 (21:46 -0600)
committerJames Bottomley <jejb@mulgrave.(none)>
Thu, 8 Dec 2005 14:13:29 +0000 (09:13 -0500)
commit85631672e6a8032267058b4ccbe53f1924a5d0be
treee1d415d226e3ef0ee44c4282ee96ef006f3a08a9
parentf0353301e6752399ceb874ede7f44e3571c5e4f3
[SCSI] fix OOPS due to clearing eh_action prior to aborting eh command

The eh_action semaphore in scsi_eh_send_command is cleared after a
command timeout.  The command is subsequently aborted and the abort
will try to call scsi_done() on it.  Unfortunately, the scsi_eh_done()
routine unconditinally completes the semaphore (which is now null).
Fix this race by makiong the scsi_eh_done() routine check that the
semaphore is non null before completing it (mirroring the ordinary
command done/timeout logic).

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/scsi_error.c