GlobalValue: Automatically reset visibility when setting local linkage
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Tue, 20 May 2014 19:00:58 +0000 (19:00 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Tue, 20 May 2014 19:00:58 +0000 (19:00 +0000)
commit8598e290c3ef00108d1e59871f7c2665be44273a
treefa119d32e300177ff4e8a772f36c4ec1d524bb65
parent1e3493b04a88fe931f73eebc175eb03c0d165e21
GlobalValue: Automatically reset visibility when setting local linkage

r208264 started asserting in `setLinkage()` and `setVisibility()` that
visibility and linkage are compatible.  There are a few places in clang
where visibility is set first, and then linkage later, so the assert
fires.  In `setLinkage()`, it's clear what the visibility *should* be,
so rather than updating all the call sites just automatically fix the
visibility.

The testcase for this is for *clang*, so it'll follow separately in cfe.

PR19760

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209227 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/IR/GlobalValue.h