PM / Sleep: Simplify generic system suspend callbacks
authorRafael J. Wysocki <rjw@sisk.pl>
Thu, 15 Dec 2011 19:59:23 +0000 (20:59 +0100)
committerRafael J. Wysocki <rjw@sisk.pl>
Sat, 17 Dec 2011 23:27:35 +0000 (00:27 +0100)
commit8ca6d9bcc8d33c592c0855b4b1481bc723ac7e85
tree2a80c117586c12bf475cd828ffdeeb67ba9e647f
parentcf007e3526a785a95a738d5a8fba44f1f4fe33e0
PM / Sleep: Simplify generic system suspend callbacks

The pm_runtime_suspended() check in __pm_generic_call() doesn't
really help and may cause problems to happen, because in some cases
the system suspend callbacks need to be called even if the given
device has been suspended by runtime PM.  For example, if the device
generally supports remote wakeup and is not enabled to wake up
the system from sleep, it should be prevented from generating wakeup
signals during system suspend and that has to be done by the
suspend callbacks that the pm_runtime_suspended() check prevents from
being executed.

Similarly, it may not be a good idea to unconditionally change
the runtime PM status of the device to 'active' in
__pm_generic_resume(), because the driver may want to leave the
device in the 'suspended' state, depending on what happened to it
before the system suspend and whether or not it is enabled to
wake up the system.

For the above reasons, remove the pm_runtime_suspended()
check from __pm_generic_call() and remove the code changing the
device's runtime PM status from __pm_generic_resume().

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
drivers/base/power/generic_ops.c