HID: wacom: Fail probe if HID_GENERIC device has unknown device_type
authorJason Gerecke <killertofu@gmail.com>
Fri, 1 May 2015 00:51:55 +0000 (17:51 -0700)
committerJiri Kosina <jkosina@suse.cz>
Mon, 4 May 2015 08:00:23 +0000 (10:00 +0200)
commit8e116d3169cc2b93b7eb2f44dc021a93cd3d5308
tree3263e6e65bb02007ae9d96e8e81d1dd59e0775b9
parent042628abd59c9a034797bd3083f806fa17cda62d
HID: wacom: Fail probe if HID_GENERIC device has unknown device_type

The last patch was careful to maintain backwards-compatible behavior
by forcing device_type to BTN_TOOL_PEN (and printing a warning) if it
were still uninitialized after scanning the HID descriptor and applying
quirks. We should be more strict with HID_GENERIC devices, however,
since there is no a priori guarantee that it is a tablet or touchpad.
If the device_type is still uninitialized for a HID_GENERIC device then
we assume that it isn't something the driver can work with and so fail
the probe.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: Ping Cheng <pingc@wacom.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/wacom_sys.c