explicit instantiation of common Future types
authorJames Sedgwick <jsedgwick@fb.com>
Mon, 4 May 2015 14:23:39 +0000 (07:23 -0700)
committerPraveen Kumar Ramakrishnan <praveenr@fb.com>
Tue, 12 May 2015 00:02:08 +0000 (17:02 -0700)
commit8e1544536fa676df7e722db0cc9de536c5879998
treeef5d5ca387ed165f29deb91bfb31450a3aec15a1
parent02bb2c340cde43595ca8aacd6585751c8e58541a
explicit instantiation of common Future types

Summary:
Compiling folly/futures:futures-test, this saves 15% (dbg) and 7% (opt)
Compiling all of folly/futures, it's 7% ish for each

Main blocker right now is that this generates a spew of deprecated warnings from calls to core_->(de)activate() from Future::(de)activate(). Can the deprecations be moved up to the Future methods instead?

Also had to fix willEqual for Future<void> which was borked

Test Plan: compiles

Reviewed By: hans@fb.com

Subscribers: trunkagent, folly-diffs@, jsedgwick, yfeldblum, chalfant

FB internal diff: D2021028

Signature: t1:2021028:1430749114:1dd78af47ea91aa5e67929a5884b66ca0c8ae2d8
folly/futures/Future-inl.h
folly/futures/Future.cpp
folly/futures/Future.h
folly/futures/detail/Core.h