[media] s5k6aa: Fix possible NULL pointer dereference
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Wed, 26 Sep 2012 08:45:21 +0000 (05:45 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 2 Oct 2012 17:01:30 +0000 (14:01 -0300)
commit94c15b5e6755711af6dd81bde0f8396e24b75dc2
tree93a7da1e0a9c7ed2cca42374055e24f70b8e457b
parent7fb89eca0f2ad21f6e77f3411cb220ed94f340df
[media] s5k6aa: Fix possible NULL pointer dereference

Make sure __s5k6aa_get_crop_rect() always returns valid pointer,
as it is assumed at the callers.
crop->which is already validated when subdev set_crop and get_crop
callbacks are called from within the v4l2-core. If it ever happens
the crop operations are called directly for some reason in kernel
space, with incorrect crop->which argument, just log it with WARN
and return reference to the TRY crop.

Reported-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/i2c/s5k6aa.c