waitWithSemaphore -> Future<T>::wait()
Summary:
see task. also adjust all callsites to get() or wait() as appropriate. this is a lot better, especially in various tests
Facebook:
cc @rushix, @wez as this was quite nice for docstore and novak, and you might want to be aware of new conventions
Test Plan: futures unit, wait for contbuild
Reviewed By: hans@fb.com
Subscribers: trunkagent, fbcode-common-diffs@, hero-diffs@, cold-storage-diffs@, adamsyta, zhuohuang, darshan, micha, folly-diffs@, lins, tingy, hannesr, jsedgwick, wez, rushix
FB internal diff:
D1785572
Tasks:
5940008
Signature: t1:
1785572:
1421866794:
a879de4d0bc14e96c434f623ed2a74361e25f28c