projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 66aeece) | patch
Fix joining threads twice when exiting EventBaseTest.RunInThread normally
authorZonr Chang <zonr.net@gmail.com>
Tue, 30 Aug 2016 22:46:50 +0000 (15:46 -0700)
committerFacebook Github Bot 4 <facebook-github-bot-4-bot@fb.com>
Tue, 30 Aug 2016 22:53:29 +0000 (15:53 -0700)
commit9b75144718da8f899feb46bb8236d0538de483dd
treecbc1a226d459cf27f3acafff0c0d3df1388bc215tree | snapshot
parent66aeece76a4345e754376b599ff6770f5a4b28afcommit | diff
Fix joining threads twice when exiting EventBaseTest.RunInThread normally

Summary:
10e9cd3 set up SCOPE_EXIT to join threads (wait for them to exit) on
exceptions. However, it is also called on normal exit. Remove the
original code at the end for joining threads.

This fixes EventBaseTest regression.
Closes https://github.com/facebook/folly/pull/468

Reviewed By: yfeldblum

Differential Revision: D3792977

Pulled By: Orvid

fbshipit-source-id: e4b12202ae3e35fd942ad2ca1d8d405cf1a28f68
folly/io/async/test/EventBaseTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.