projects / firefly-linux-kernel-4.4.55.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7532c7d) | patch
mwl8k: don't return zero on failure paths in mwl8k_probe[_hw]()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Fri, 18 Jan 2013 21:24:01 +0000 (01:24 +0400)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 22 Jan 2013 21:01:30 +0000 (16:01 -0500)
commita2ca8ecb8ffc985e82c9570c3837408f7efe8c9d
tree571b1266c73e1c7ab993245c792a9feb9e96cd98tree | snapshot
parent7532c7d0138a4984eb0c8b12b9c310cf8a6d6977commit | diff
mwl8k: don't return zero on failure paths in mwl8k_probe[_hw]()

If pci_iomap() fails in mwl8k_probe(), it breaks off initialization,
deallocates all resources, but returns zero.
There is a similar issue when priv->rxd_ops is NULL in mwl8k_probe_hw().

The patch adds proper error code return values.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwl8k.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.