Start deciding earlier what to link.
authorRafael Espindola <rafael.espindola@gmail.com>
Mon, 30 Nov 2015 22:01:43 +0000 (22:01 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Mon, 30 Nov 2015 22:01:43 +0000 (22:01 +0000)
commita586fd2c5665c75c1b2870b1361d794ac25caf9e
treedcff8cccb600d1c6b43cd78ee5e6f53c28c59f09
parentae5d4bfbbefb29e8759287f13bc1d3bb44474044
Start deciding earlier what to link.

A traditional linker is roughly split in symbol resolution and "copying
stuff".

The two tasks are badly mixed in lib/Linker.

This starts splitting them apart.

With this patch there are no direct call to linkGlobalValueBody or
linkGlobalValueProto. Everything is linked via WapValue.

This also includes a few fixes:
* A GV goes undefined if the comdat is dropped (comdat11.ll).
* We error if an internal GV goes undefined (comdat13.ll).
* We don't link an unused comdat.

The first two match the behavior of an ELF linker. The second one is
equivalent to running globaldce on the input.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254336 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Linker/LinkModules.cpp
lib/Transforms/Utils/ValueMapper.cpp
test/Linker/Inputs/comdat11.ll [new file with mode: 0644]
test/Linker/Inputs/comdat13.ll [new file with mode: 0644]
test/Linker/comdat11.ll [new file with mode: 0644]
test/Linker/comdat12.ll [new file with mode: 0644]
test/Linker/comdat13.ll [new file with mode: 0644]
test/Linker/comdat9.ll