ARM: shmobile: lager: do not annotate gpio_buttons as __initdata
authorSimon Horman <horms+renesas@verge.net.au>
Fri, 26 Jul 2013 08:53:42 +0000 (17:53 +0900)
committerSimon Horman <horms+renesas@verge.net.au>
Wed, 31 Jul 2013 01:11:17 +0000 (10:11 +0900)
commita601469386b543df2a4d97ad7d524716945278a3
treef81f38cfb2351352bb9bbdffe01b61c468e86be2
parentfa3e0cee12fbdd9e0b03470b2b8cf968f537c161
ARM: shmobile: lager: do not annotate gpio_buttons as __initdata

When the gpio-keys device is registered using
platform_device_register_data() the platform data argument,
lager_keys_pdata is duplicated and thus should be marked as __initdata
to avoid wasting memory. However, this is not true of gpio_buttons,
a reference to it rather than its value is duplicated when lager_keys_pdata
is duplicated.

This avoids accessing freed memory if gpio-key events occur
after unused kernel memory is freed late in the kernel's boot.

This but was added when support for gpio-keys was added to lager
in c3842e4fcbb7664276443b79187b7808c2e80a35
("ARM: shmobile: lager: support GPIO switches") which was included
in v3.11-rc1.

Tested-by: Magnus Damm <damm@opensource.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
arch/arm/mach-shmobile/board-lager.c