Make fbstring libgcc-safe
authorNicholas Ormrod <njormrod@fb.com>
Wed, 18 Jun 2014 16:35:10 +0000 (09:35 -0700)
committerAnton Likhtarov <alikhtarov@fb.com>
Thu, 26 Jun 2014 02:24:24 +0000 (19:24 -0700)
commita97b3be50704647a2df0b36f54ad17b1e7151d31
tree74dcea1737861939cb1a2cca10faad2e6d4de4df
parent58d27d0059f83f3e608d30da331c4b938c005f2b
Make fbstring libgcc-safe

Summary:
Some libgcc-incompatible code has been added to fbstring.
Removed/reorganized it so that we can drop fbstring right into libgcc.

Test Plan:
fbconfig -r folly && fbmake runtests

Copied FBString.h into libgcc's basic_fbstring.h, with no modifications.
Successfully tp2_build libgcc/4.8.1. Adjusted symlink, then fbmake clean
&& fbconfig -r folly && fbmake dbg. The fbmake dbg failed with an
assertion error, which is consistent with @lucian's observations in
D1373725; the important part is that the error was at runtime, so the
compile-time changes of this diff looks good.

Reviewed By: lucian@fb.com

Subscribers: folly@lists, sdwilsh, njormrod, lucian

FB internal diff: D1382873
folly/FBString.h