llvm-dis: Stop crashing when dropping debug info
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Wed, 25 Feb 2015 01:10:03 +0000 (01:10 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Wed, 25 Feb 2015 01:10:03 +0000 (01:10 +0000)
commitaaff953db4f72876e481e16e352c7488b5643fb4
treed9653adce570ee39c269e8dceb3914869d52c3c6
parent6606ad944bb4e88fc41dca522c02f8f8d54aab2d
llvm-dis: Stop crashing when dropping debug info

Since r199356, we've printed a warning when dropping debug info.
r225562 started crashing on that, since it registered a diagnostic
handler that only expected errors.  This fixes the handler to expect
other severities.  As a side effect, it now prints "error: " at the
start of error messages, similar to `llvm-as`.

There was a testcase for r199356, but it only really checked the
assembler.  Move `test/Bitcode/drop-debug-info.ll` to `test/Assembler`,
and introduce `test/Bitcode/drop-debug-info.3.5.ll` (and companion
`.bc`) to test the bitcode reader.

Note: tools/gold/gold-plugin.cpp has an equivalent bug, but I'm not sure
what the best fix is there.  I'll file a PR.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230416 91177308-0d34-0410-b5e6-96231b3b80d8
test/Assembler/drop-debug-info.ll [new file with mode: 0644]
test/Bitcode/drop-debug-info.3.5.ll [new file with mode: 0644]
test/Bitcode/drop-debug-info.3.5.ll.bc [new file with mode: 0644]
test/Bitcode/drop-debug-info.ll [deleted file]
test/Bitcode/invalid.ll
test/Bitcode/pr18704.ll
tools/llvm-dis/llvm-dis.cpp