projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6e8fcd1) | patch
Force the overflow in BitVectorCoding::skipTo to be 64-bit
authorChristopher Dykes <cdykes@fb.com>
Wed, 3 Aug 2016 22:09:04 +0000 (15:09 -0700)
committerFacebook Github Bot 4 <facebook-github-bot-4-bot@fb.com>
Wed, 3 Aug 2016 22:23:47 +0000 (15:23 -0700)
commitabb963a06d6f2b7f6d39bbe34c5b6d581d79480e
treeaa448cbb8ecc8099e10bf05b9a35fb15517ccfd0tree | snapshot
parent6e8fcd168c0edf827e6f828bf81f52b661e8d17ccommit | diff
Force the overflow in BitVectorCoding::skipTo to be 64-bit

Summary: This code was relying on the `- 1` overflowing as a 64-bit value, but MSVC (correctly in my opinion) was overflowing this as a 32-bit value, resulting in a segfault when trying to run the bitvector and eliasfano tests on MSVC.

Reviewed By: yfeldblum

Differential Revision: D3652343

fbshipit-source-id: 38a22abfc0d05ab2f070c450eebfa69af07d26af
folly/experimental/BitVectorCoding.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.