fix AsyncServerSocket::bind issue
authorPhilip Pronin <philipp@fb.com>
Tue, 3 Feb 2015 07:53:46 +0000 (23:53 -0800)
committerAndrew Cox <andrewcox@fb.com>
Wed, 4 Feb 2015 21:03:23 +0000 (13:03 -0800)
commitad4a9ff72a9bc385a01f075f977f29eb805fd127
tree81350ada75306ed3b5b493ee91660c0e16c1015a
parentd8386e3435de6422c2bac847410dcadb98288c6c
fix AsyncServerSocket::bind issue

Summary:
When closing sockets on retry, we should use `shutdownSocketSet_`
if it is set (so socket will properly be removed from the set).

Also I changed all `::close()` and `::shutdown()` calls to `*NoInt()`
version.

Test Plan:
fbconfig unicorn/test:basic_compression_test && fbmake opt -j32
while _bin/unicorn/test/test:basic_compression_test; do echo DONE; done

Reviewed By: mcduff@fb.com

Subscribers: trunkagent, folly-diffs@, yzhan, yfeldblum

FB internal diff: D1821104

Tasks: 47525796123510

Signature: t1:1821104:1423001050:5bc09ffdd6666c2884ea82dbd70831a56513cfc9

Blame Revision: D1795120
folly/io/async/AsyncServerSocket.cpp