locking/mutexes/mcs: Correct barrier usage
authorWaiman Long <Waiman.Long@hp.com>
Tue, 21 Jan 2014 23:35:53 +0000 (15:35 -0800)
committerIngo Molnar <mingo@kernel.org>
Tue, 28 Jan 2014 12:13:26 +0000 (13:13 +0100)
commitaff7385b5a16bca6b8d9243f01a9ea5a5b411e1d
treeca8b03e4e6aa1d0fcd8ae971e98b0719fdb08666
parent270750dbc18a71b23d660df110e433ff9616a2d4
locking/mutexes/mcs: Correct barrier usage

This patch corrects the way memory barriers are used in the MCS lock
with smp_load_acquire and smp_store_release fucnctions.  The previous
barriers could leak critical sections if mcs lock is used by itself.
It is not a problem when mcs lock is embedded in mutex but will be an
issue when the mcs_lock is used elsewhere.

The patch removes the incorrect barriers and put in correct
barriers with the pair of functions smp_load_acquire and smp_store_release.

Suggested-by: Michel Lespinasse <walken@google.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Waiman Long <Waiman.Long@hp.com>
Signed-off-by: Jason Low <jason.low2@hp.com>
Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1390347353.3138.62.camel@schen9-DESK
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/mutex.c