projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: eb0730c) | patch
CodeMod: Prefer ADD_FAILURE() over EXPECT_TRUE(false), et cetera
authorYedidya Feldblum <yfeldblum@fb.com>
Mon, 17 Jul 2017 04:23:33 +0000 (21:23 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Mon, 17 Jul 2017 04:37:27 +0000 (21:37 -0700)
commitb15db0d83e11c8863ef6f57f1bac5dec846eaa00
tree66373b7a6b81d40370cb3bbad2acc665dd74c0e0tree | snapshot
parenteb0730c9e59c6596902e7b3ac2cfdc606449c2aecommit | diff
CodeMod: Prefer ADD_FAILURE() over EXPECT_TRUE(false), et cetera

Summary:
CodeMod: Prefer `ADD_FAILURE()` over `EXPECT_TRUE(false)`, et cetera.

The tautologically-conditioned and tautologically-contradicted boolean expectations/assertions have better alternatives: unconditional passes and failures.

Reviewed By: Orvid

Differential Revision:
D5432398

Tags: codemod, codemod-opensource

fbshipit-source-id: d16b447e8696a6feaa94b41199f5052226ef6914
12 files changed:
folly/futures/test/HeaderCompileTest.cpp diff | blob | history
folly/io/async/test/HHWheelTimerSlowTests.cpp diff | blob | history
folly/io/test/IOBufCursorTest.cpp diff | blob | history
folly/test/ConvTest.cpp diff | blob | history
folly/test/EnumerateTest.cpp diff | blob | history
folly/test/ExceptionWrapperTest.cpp diff | blob | history
folly/test/ExpectedTest.cpp diff | blob | history
folly/test/FileTest.cpp diff | blob | history
folly/test/LifoSemTests.cpp diff | blob | history
folly/test/RangeTest.cpp diff | blob | history
folly/test/StringTest.cpp diff | blob | history
folly/test/ThreadLocalTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.