Replace Subprocess::pipe* syntax sugar with Subprocess::Options().pipe*
authorAlexey Spiridonov <lesha@fb.com>
Wed, 12 Apr 2017 21:43:04 +0000 (14:43 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 12 Apr 2017 21:55:36 +0000 (14:55 -0700)
commitb4bcc1a7ce2999de5802d6ca6eada3152869c54c
tree10303abc0061c00fc8719f7de79e463030e09a42
parent0e5ec48b7d2e3c04b5b0454144b2e183d64e16ac
Replace Subprocess::pipe* syntax sugar with Subprocess::Options().pipe*

Summary:
This is a bit too magical -- it's not clear that the thing produces an Options object. If you do know that you can chain further option setters off this thing, it's nice, but otherwise, the first impression is "what just happened?".

So, let's have one good way for doing things.

Reviewed By: yfeldblum

Differential Revision: D4863947

fbshipit-source-id: 3dfe83cfc077d47f604f47dcb21149fbaa2d2243
folly/Subprocess.h
folly/experimental/test/ProgramOptionsTest.cpp
folly/test/SubprocessTest.cpp
folly/tracing/test/StaticTracepointTest.cpp