bcache: fix race of writeback thread starting before complete initialization
authorEric Wheeler <git@linux.ewheeler.net>
Fri, 26 Feb 2016 22:39:06 +0000 (14:39 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Apr 2016 16:08:53 +0000 (09:08 -0700)
commitb58e781068d9a5fd6b0ee77f595c3dbaa0d2b7aa
tree0e598e2780aed5a4ce4a85d130d15423f900383e
parent32bb1185093c67c2280e440685ebc6b23fd47743
bcache: fix race of writeback thread starting before complete initialization

commit 07cc6ef8edc47f8b4fc1e276d31127a0a5863d4d upstream.

The bch_writeback_thread might BUG_ON in read_dirty() if
dc->sb==BDEV_STATE_DIRTY and bch_sectors_dirty_init has not yet completed
its related initialization.  This patch downs the dc->writeback_lock until
after initialization is complete, thus preventing bch_writeback_thread
from proceeding prematurely.

See this thread:
  http://thread.gmane.org/gmane.linux.kernel.bcache.devel/3453

Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net>
Tested-by: Marc MERLIN <marc@merlins.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/bcache/super.c