Suppress more warnings for MSVC
authorAndrew Krieger <andrew.krieger@oculus.com>
Fri, 14 Apr 2017 21:36:30 +0000 (14:36 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Fri, 14 Apr 2017 21:51:32 +0000 (14:51 -0700)
commitb5e4bc034ee27308714f9fd7b3f1a6d5c75ac2bf
tree1e96be4ecce6f82db8c71e410b53b84a03e715fe
parentbfdfe5e42dcc01a346ce157530101df6d50df234
Suppress more warnings for MSVC

Summary:
Several other warnings that aren't reasonable to disable globally occur in folly headers.

- Wrap the unreachable code warnings in MSVC specific disable blocks to prevent problems for users.
- Use more careful bit twiddling instead of negating unsigned types
- Enable a simpler overload for bool->float conversion than one which attempts float->bool.
- Delete one unneeded undef.

Reviewed By: yfeldblum

Differential Revision: D4891583

fbshipit-source-id: 4d2efda1fe720abcb083bf29b578c065127cda24
folly/Conv.h
folly/Expected.h
folly/Hash.h
folly/portability/Windows.h