of/platform: Use platform_device interface
authorRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Tue, 26 May 2015 07:31:25 +0000 (09:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jun 2015 01:15:17 +0000 (10:15 +0900)
commitb6d2233f2916fa9338786aeab2e936c5a07e4d0c
tree240b9538c9291219491d3d394fd8af4a17707232
parente50e69d1ac4232af0b6890f16929bf5ceee81538
of/platform: Use platform_device interface

of_platform_device_create_pdata() was using of_device_add() to create
the devices, but of_platform_device_destroy was using
platform_device_unregister() to free them.

of_device_add(), do not call insert_resource(), which initializes the
parent field of the resource structure, needed by release_resource(),
called by of_platform_device_destroy(). This leads to a NULL pointer
deference.

Instead of fixing the NULL pointer deference, what could hide other bugs,
this patch, replaces of_device_add() with platform_device_data().

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/of/platform.c