Re-commit r192758 - MC: quote tricky symbol names in asm output
authorHans Wennborg <hans@hanshq.net>
Thu, 17 Oct 2013 01:13:02 +0000 (01:13 +0000)
committerHans Wennborg <hans@hanshq.net>
Thu, 17 Oct 2013 01:13:02 +0000 (01:13 +0000)
commitb74b88edac9ab490ba428aef0bdebc957399bbd7
tree58dfe9bdbad54da6018b7a8159f9283d9179bce0
parent88a68cbbb57aa9caef60dbd2f63d908983e77465
Re-commit r192758 - MC: quote tricky symbol names in asm output

The reason this got reverted was that the @feat.00 symbol which was emitted
for every TU became quoted, and on cygwin/mingw we use the gas assembler which
couldn't handle the quotes.

This commit fixes the problem by only emitting @feat.00 for win32, where we use
clang -cc1as to assemble. gas would just drop this symbol anyway, so there is no
loss there.

With @feat.00 gone, there shouldn't be quoted symbols showing up on cygwin since
it uses the Itanium ABI, which doesn't put these funny characters in symbols.

> Because of win32 mangling, we produce symbol and section names with
> funny characters in them, most notably @ characters.
>
> MC would choke on trying to parse its own assembly output. This patch addresses
> that by:
>
> - Making @ trigger quoting of symbol names
> - Also quote section names in the same way
> - Just parse section names like other identifiers (to allow for quotes)
> - Don't assume @ signifies a symbol variant if it is in a string.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192859 91177308-0d34-0410-b5e6-96231b3b80d8
lib/MC/MCParser/AsmParser.cpp
lib/MC/MCParser/COFFAsmParser.cpp
lib/MC/MCSectionCOFF.cpp
lib/MC/MCSymbol.cpp
lib/Target/X86/X86AsmPrinter.cpp
test/CodeGen/X86/coff-feat00.ll
test/CodeGen/X86/fastcall-correct-mangling.ll
test/CodeGen/X86/stdcall.ll
test/MC/COFF/quoted-names.ll [new file with mode: 0644]