zram: avoid invalid memory access in zram_exit()
authorJiang Liu <liuj97@gmail.com>
Thu, 6 Jun 2013 16:07:22 +0000 (00:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Aug 2013 01:35:23 +0000 (18:35 -0700)
commitb74c38d5b6af46482480f6f8b83633e2971a0ed8
tree23baeb18e5dba18a99404509006583bcc7947e5c
parent14d33c9b86b368fd6cab62e61074fa115018f1f8
zram: avoid invalid memory access in zram_exit()

commit 6030ea9b35971a4200062f010341ab832e878ac9 upstream.

Memory for zram->disk object may have already been freed after returning
from destroy_device(zram), then it's unsafe for zram_reset_device(zram)
to access zram->disk again.

We can't solve this bug by flipping the order of destroy_device(zram)
and zram_reset_device(zram), that will cause deadlock issues to the
zram sysfs handler.

So fix it by holding an extra reference to zram->disk before calling
destroy_device(zram).

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/zram/zram_drv.c