Eliminate more VLAs
authorChristopher Dykes <cdykes@fb.com>
Tue, 1 Nov 2016 18:24:18 +0000 (11:24 -0700)
committerFacebook Github Bot <facebook-github-bot-bot@fb.com>
Tue, 1 Nov 2016 18:38:40 +0000 (11:38 -0700)
commitbc32ffeaae78373e5fe057a82e6d00edc2672737
tree86bdf885553d1a10f55f1af31996522b78c9573f
parentb106dcc786b834c250c74450a66a44a223eb0140
Eliminate more VLAs

Summary:
MSVC doesn't support them, so use dynamic allocation instead.
This also fixes a place where MSVC wasn't propogating the constexpr-ness of a local into the body of a lambda, resulting in an attempt to create a VLA.

Reviewed By: yfeldblum

Differential Revision: D4098932

fbshipit-source-id: 742b2fcd96f7f6eceb5043159403d557f7fc9673
folly/fibers/test/FibersTest.cpp
folly/test/StringTest.cpp