projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2c111cf) | patch
(Wangle) Fix bug with CrappyExecutors, and bad PriorityExecutor
authorHannes Roth <hannesr@fb.com>
Thu, 25 Jun 2015 15:38:14 +0000 (08:38 -0700)
committerSara Golemon <sgolemon@fb.com>
Fri, 26 Jun 2015 18:45:37 +0000 (11:45 -0700)
commitbe98381373e5a727224f9fa74e45a067e67b54f0
tree9a249cfbd5f3191f4b69df5a9e03232265edd519tree | snapshot
parent2c111cff3015b80a86ab16d3f1edee934bc25e59commit | diff
(Wangle) Fix bug with CrappyExecutors, and bad PriorityExecutor

Summary: 1) We forgot to `--attached_` if `x` throws an exception
2) `PriorityExecutor` didn't execute `Func`, causing leaks in the test (not a bug in Futures)
3) I moved up the initialization for an empty `Core` into the constructor to make it easier to see

Reviewed By: @jsedgwick

Differential Revision: D2187343
folly/futures/detail/Core.h diff | blob | history
folly/futures/test/ViaTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.