fix flaky test from uninitialized std::atomic
authorNathan Bronson <ngbronson@fb.com>
Wed, 8 Oct 2014 23:59:27 +0000 (16:59 -0700)
committerAndrii Grynenko <andrii@fb.com>
Wed, 15 Oct 2014 00:56:03 +0000 (17:56 -0700)
commitbf035046df458d07d274965ab5b09572f0985715
treeb1f15f81ebcab362184c57bb20139ca826049ed8
parentb6f62e958838d8855980c6713db536a125a0a5fb
fix flaky test from uninitialized std::atomic

Summary:
std::atomic<bool> default constructor doesn't initialize it to
false, so the flag to end the LifoSem.multi_try_wait test was sometimes
set too early.  This diff fixes that, makes the test more deterministic,
and also fixes a couple of other benign uninitialized values (so that
they won't be used as prototypes for places where it does matter).

Test Plan: unit tests

Reviewed By: mpawlowski@fb.com

Subscribers: njormrod, lovro

FB internal diff: D1604508

Tasks: 5336837
folly/test/CacheLocalityTest.cpp
folly/test/LifoSemTests.cpp