projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b674659) | patch
Don't attempt to separately close the underlying file descriptor in the format other...
authorChristopher Dykes <cdykes@fb.com>
Sat, 19 Nov 2016 01:54:36 +0000 (17:54 -0800)
committerFacebook Github Bot <facebook-github-bot-bot@fb.com>
Sat, 19 Nov 2016 02:08:53 +0000 (18:08 -0800)
commitbf44ef993a2db0bc76af0fa2ded445d09d99043f
tree64a51b48515a986ac8d02a86e2133e585aa7088ftree | snapshot
parentb6746598f0ad8cbcbe0b0da90c035ba5d3f1aab7commit | diff
Don't attempt to separately close the underlying file descriptor in the format other test

Summary: Windows automatically closes the underlying file descriptor when you call fclose, however fclose is not a function that can be easily overriden in the portability layer, so choose to just not call `close` on Windows instead.

Reviewed By: yfeldblum

Differential Revision: D4190524

fbshipit-source-id: a68edccd04e63f89c178ade584fa7192845773f8
folly/Portability.h diff | blob | history
folly/test/FormatOtherTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.