Remove DFATAL from folly::Singleton::try_get()
Summary: try_get() API is confusing right now, because it returns nullptr in release, but crashes in debug build. Users end up handling nullptr returns, yet their code crashes in debug builds for no reason. See https://www.facebook.com/groups/fbthrift/permalink/
1222120054481561/ for an example.
If we want to keep the crashing API we should probably name it differently and make it crash both in debug and release.
Reviewed By: dhruvbird
Differential Revision:
D2587818
fb-gh-sync-id:
5834bfa08eb5d9bc6db1c5edf4a048a5b1d3212c