ext4: prevent ext4_quota_write() from failing due to ENOSPC
authorTheodore Ts'o <tytso@mit.edu>
Sun, 21 Jun 2015 05:25:29 +0000 (01:25 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 21 Jun 2015 05:25:29 +0000 (01:25 -0400)
commitc5e298ae53dc2eb69f2f7153be03454c8a33c658
tree07bd2e74badcff3d55627b2f315b1640bbde15d8
parent89d96a6f8e6491f24fc8f99fd6ae66820e85c6c1
ext4: prevent ext4_quota_write() from failing due to ENOSPC

In order to prevent quota block tracking to be inaccurate when
ext4_quota_write() fails with ENOSPC, we make two changes.  The quota
file can now use the reserved block (since the quota file is arguably
file system metadata), and ext4_quota_write() now uses
ext4_should_retry_alloc() to retry the block allocation after a commit
has completed and released some blocks for allocation.

This fixes failures of xfstests generic/270:

Quota error (device vdc): write_blk: dquota write failed
Quota error (device vdc): qtree_write_dquot: Error -28 occurred while creating quota

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c
fs/ext4/indirect.c
fs/ext4/inode.c
fs/ext4/namei.c
fs/ext4/super.c