arm64: mm: detect bad __create_mapping uses
authorMark Rutland <mark.rutland@arm.com>
Mon, 23 Nov 2015 13:26:19 +0000 (13:26 +0000)
committerAlex Shi <alex.shi@linaro.org>
Wed, 11 May 2016 07:54:49 +0000 (15:54 +0800)
commitcc798dcca00a8b71e5c09a38d3921461f931c85f
treedb58eec660aa2fa420b95bd273d6ae6017329776
parent1a1a512b983108015ced1e7a7c7775cfeec42d8c
arm64: mm: detect bad __create_mapping uses

If a caller of __create_mapping provides a PA and VA which have
different sub-page offsets, it is not clear which offset they expect to
apply to the mapping, and is indicative of a bad caller.

In some cases, the region we wish to map may validly have a sub-page
offset in the physical and virtual addresses. For example, EFI runtime
regions have 4K granularity, yet may be mapped by a 64K page kernel. So
long as the physical and virtual offsets are the same, the region will
be mapped at the expected VAs.

Disallow calls with differing sub-page offsets, and WARN when they are
encountered, so that we can detect and fix such cases.

Cc: Laura Abbott <labbott@fedoraproject.org>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Steve Capper <steve.capper@linaro.org>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
(cherry picked from commit cc5d2b3b95cdbb3fed4e38e667d17b9ac7250f7a)
Signed-off-by: Alex Shi <alex.shi@linaro.org>
arch/arm64/mm/mmu.c