Remove `unsigned char v = static_cast<unsigned char>(v);`
authorOrvid King <blah38621@gmail.com>
Mon, 17 Aug 2015 17:37:08 +0000 (10:37 -0700)
committerfacebook-github-bot-1 <folly-bot@fb.com>
Mon, 17 Aug 2015 18:20:24 +0000 (11:20 -0700)
commitcd69a53aed1a97579a45d48e5a82786651f568df
tree1a4c479101b154c5a4337fc330d0f09d1969f4be
parent9af380441971bc1d285c1c64cea3e3d80fe45079
Remove `unsigned char v = static_cast<unsigned char>(v);`

Summary: MSVC spotted this very suspicious line when I was running it with /analyze, and complained about using an unitialized variable. This variable isn't used anywhere in the function, and is initializing itself with itself. I have no idea how this compiled in the first place, but apparently it does.
This removes the line in question.
Closes #295

Reviewed By: @yfeldblum, @paulbiss

Differential Revision: D2340688

Pulled By: @sgolemon
folly/String-inl.h