bonding: fix race condition in bonding_store_slaves_active
authornikolay@redhat.com <nikolay@redhat.com>
Thu, 29 Nov 2012 01:37:59 +0000 (01:37 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Jan 2013 17:03:35 +0000 (09:03 -0800)
commitcefbc0583507deea5f6fd6232909761e0c3cc01a
treef7d09e671839829cfbdbd55698b7e96c1b3a9ea0
parenta8695e1c800bcf21dc9cf55044dd749a3f805427
bonding: fix race condition in bonding_store_slaves_active

[ Upstream commit e196c0e579902f42cf72414461fb034e5a1ffbf7 ]

Race between bonding_store_slaves_active() and slave manipulation
 functions. The bond_for_each_slave use in bonding_store_slaves_active()
 is not protected by any synchronization mechanism.
 NULL pointer dereference is easy to reach.
 Fixed by acquiring the bond->lock for the slave walk.

 v2: Make description text < 75 columns

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/bonding/bond_sysfs.c