prvalues from get_ref_default()'s default functor
authorTom Jackson <tjackson@fb.com>
Thu, 8 Sep 2016 09:36:58 +0000 (02:36 -0700)
committerFacebook Github Bot 9 <facebook-github-bot-9-bot@fb.com>
Thu, 8 Sep 2016 09:38:29 +0000 (02:38 -0700)
commitcf784212df2255844336b7ff0c7d36ee9037fa88
treecefe7599bc643d134121dc84b5dba0ee578f5458
parentdd6fff7166b6fe157ae5bc64366969ffb5fd1b7d
prvalues from get_ref_default()'s default functor

Summary: This previously allowed `get_ref_default(map, 4, []{ return 6; })`, even though this would form a reference to a temporary, then **use that invalid reference**.

Reviewed By: yfeldblum

Differential Revision: D3802707

fbshipit-source-id: 384d965f69c9d7b6bd3f011c8eff7fe55be7023a
folly/MapUtil.h
folly/test/MapUtilTest.cpp