md/raid1: fix counting of write targets.
authorNeilBrown <neilb@suse.de>
Tue, 18 May 2010 05:27:13 +0000 (15:27 +1000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:10:45 +0000 (11:10 -0700)
commitd067b0b81ddd913cfd3694cc819d86f1048b58bd
treea15f3450ce9e4c6b0e6444aed9193adbb462746c
parent584516620656c12f751d9714240d3056bcf76fca
md/raid1: fix counting of write targets.

commit 964147d5c86d63be79b442c30f3783d49860c078 upstream.

There is a very small race window when writing to a
RAID1 such that if a device is marked faulty at exactly the wrong
time, the write-in-progress will not be sent to the device,
but the bitmap (if present) will be updated to say that
the write was sent.

Then if the device turned out to still be usable as was re-added
to the array, the bitmap-based-resync would skip resyncing that
block, possibly leading to corruption.  This would only be a problem
if no further writes were issued to that area of the device (i.e.
that bitmap chunk).

Suitable for any pending -stable kernel.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/md/raid1.c