projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 499cf20) | patch
Remove runInLoop
authorAndrii Grynenko <andrii@fb.com>
Fri, 10 Mar 2017 04:34:14 +0000 (20:34 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Fri, 10 Mar 2017 04:55:38 +0000 (20:55 -0800)
commitd9bf016dbcafb3c7c3fac4d081c5e63bed6516c5
tree6e8325f504e8f699e3494970b9caab7f3e84259ctree | snapshot
parent499cf208b86085e7b870843e7e4a2e26c13c1a68commit | diff
Remove runInLoop

Summary: Existing runInLoop implementation was generally not safe (it did not capture the KeepAlive token). runInLoop() is mostly used in library code though, and often times it's ok not capture the KeepAlive token. It's better to just have the caller make the decision, rather then keep runInLoop() and make it always capture the KeepAlive token.

Reviewed By: yfeldblum

Differential Revision: D4684025

fbshipit-source-id: 65907bbe9c774e2a7b92580d0c0387d346b495d5
folly/fibers/EventBaseLoopController-inl.h diff | blob | history
folly/io/async/VirtualEventBase.cpp diff | blob | history
folly/io/async/VirtualEventBase.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.